Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT-1099: Migrate test 071_commented_yaml_regression_3568_tests #6106

Merged
merged 1 commit into from
Oct 20, 2022
Merged

CT-1099: Migrate test 071_commented_yaml_regression_3568_tests #6106

merged 1 commit into from
Oct 20, 2022

Conversation

peterallenwebb
Copy link
Contributor

resolves #5730

Description

Migrates test 071_commented_yaml_regression_3568_tests to the new framework

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner October 19, 2022 19:52
@cla-bot cla-bot bot added the cla:yes label Oct 19, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb peterallenwebb added the Skip Changelog Skips GHA to check for changelog file label Oct 19, 2022
emmyoop
emmyoop approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@peterallenwebb peterallenwebb merged commit 53ae325 into main Oct 20, 2022
@peterallenwebb peterallenwebb deleted the paw/ct-1099-test-conversion-071 branch October 20, 2022 16:43
@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may nathaniel-may was automatically assigned from dbt-labs/core-group

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt colin-rogers-dbt was automatically assigned from dbt-labs/core-group

@gshank gshank Awaiting requested review from gshank

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1099] 071_commented_yaml_regression_3568_tests
2 participants
@peterallenwebb @emmyoop