-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seed rewrite #618
Merged
Merged
Seed rewrite #618
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
4343697
loader for seed data files
0bf8489
Functioning rework of seed task
5b3cf6f
Make CompilerRunner fns private and impl. SeedRunner.compile
4899e0b
Test changes and fixes
28d2886
make the DB setup script usable locally
dbac3c5
convert simple copy test to use seeed
07f283f
Fixes to get Snowflake working
935d2a5
New seed flag and make it non-destructive by default
e49cab0
Convert update SQL script to another seed
434e7b7
cleanup
23a01ce
implement bigquery csv load
584578f
context handling of StringIO
936e68e
Better typing
224174a
strip seeder and csvkit dependency
ce25e78
update bigquery to use new data typing and to fix unicode issue
5b97a86
update seed test
e9b5795
fix abstract functions in base adapter
b86159f
support time type
797a966
try pinning crypto, pyopenssl versions
34f5e41
Merge branch 'development' of github.com:fishtown-analytics/dbt into …
4f67dca
remove unnecessary version pins
58b98f0
insert all at once, rather than one query per row
90380d5
do not quote field names on creation
04b05a2
merge development
122fba7
bad
3688286
quiet down parsedatetime logger
256fca0
pep8
e60a55c
Merge branch 'development' into seed-rewrite
drewbanin f15044f
UI updates + node conformity for seed nodes
drewbanin 868d338
add seed to list of resource types, cleanup
drewbanin 0b0c423
show option for CSVs
drewbanin 6d9af2b
typo
drewbanin 4a49afd
pep8
drewbanin f518505
move agate import to avoid strange warnings
drewbanin 9d92eb6
deprecation warning for --drop-existing
drewbanin c597803
quote column names in seed files
drewbanin c86f086
Merge branch 'development' into seed-rewrite
drewbanin 97b616e
revert quoting change (breaks Snowflake). Hush warnings
drewbanin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why go with this approach here, instead of getting the max length using http://agate.readthedocs.io/en/1.6.0/api/aggregations.html#agate.MaxLength (similar to
convert_number_type
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PostgreSQL and Snowflake both treat the N portion of
varchar(N)
as the number of characters whereas in Redshift, N is the number of bytes. I could use the same logic and the N in PG / Snowflake would be 3-4x higher than necessary, which isn't a big deal. But I figured since there is no performance difference with using "text" I would just isolate where finding the max length happens.