Ct 1518/convert 063 relation names tests #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation. Adapt and reenable previously skipped test.
McKnight-42
reviewed
Nov 29, 2022
Comment on lines
+78
to
+81
| # Backup table name generation: | ||
| # 1. for len(relation name) <= 51, backfills | ||
| # 2. for len(relation name) > 51 characters, overwrites | ||
| # the last 12 characters with __dbt_backup |
There was a problem hiding this comment.
nit: does this still need to be here?
There was a problem hiding this comment.
Absolutely imo. It's the comments that explain what's going on with the backup name truncation rules!
McKnight-42
approved these changes
Nov 29, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6274
Description
Conversion of a test, but I took the time to shape them up for modern standards and rewrite code/document it in a way (I hope) that makes their intent more readable.
Checklist