Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ct 288/convert 070 incremental test #6330

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Ct 288/convert 070 incremental test #6330

merged 4 commits into from
Nov 29, 2022

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Nov 29, 2022 •
edited
Loading

Addresses #6331

Description

Pretty standard conversion. Just a lot of movement and restructuring.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Nov 29, 2022
@VersusFacit VersusFacit self-assigned this Nov 29, 2022
@VersusFacit VersusFacit requested a review from a team as a code owner November 29, 2022 09:50
@cla-bot cla-bot bot added the cla:yes label Nov 29, 2022
@VersusFacit VersusFacit mentioned this pull request Nov 29, 2022
Open
72 tasks
@VersusFacit
Copy link
Contributor Author

VersusFacit commented Nov 29, 2022 •
edited
Loading

Oh, do we want these imported into any repos? Incremental tests have so many caveats, I'm unsure a direct import is valuable in this case.

All I did was convert the postgres__ tests to ordinary tests to live in tests/functional

@VersusFacit VersusFacit requested review from mikealfare and removed request for peterallenwebb November 29, 2022 09:58
McKnight-42
McKnight-42 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really like these tests!!!

@VersusFacit VersusFacit merged commit c3be975 into main Nov 29, 2022
@VersusFacit VersusFacit deleted the CT-288/convert_070_incremental_test branch November 29, 2022 20:47
@jtcohen6 jtcohen6 mentioned this pull request Jan 14, 2023
Merged
5 tasks
@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@Fleid Fleid Awaiting requested review from Fleid Fleid was automatically assigned from dbt-labs/core-group

@mikealfare mikealfare Awaiting requested review from mikealfare

Assignees

@VersusFacit VersusFacit

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VersusFacit @McKnight-42