Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1940] Stand-alone Python module for PostgresColumn #6773

Merged
merged 1 commit into from
Jan 28, 2023
Merged

[CT-1940] Stand-alone Python module for PostgresColumn #6773

merged 1 commit into from
Jan 28, 2023

Conversation

nssalian
Copy link
Contributor

@nssalian nssalian commented Jan 28, 2023 •
edited
Loading

resolves #6772

Description

Split out the PostgresColumn class into its own module to match the convention in other adapters

Checklist

@nssalian nssalian requested review from a team as code owners January 28, 2023 00:30
@cla-bot cla-bot bot added the cla:yes label Jan 28, 2023
dbeatty10
dbeatty10 approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 🥇

@nssalian nssalian merged commit a8abc49 into main Jan 28, 2023
@nssalian nssalian deleted the ns/ct-1940-pythonmodule-postgrescolumn branch January 28, 2023 01:00
@iknox-fa iknox-fa restored the ns/ct-1940-pythonmodule-postgrescolumn branch January 30, 2023 21:13
iknox-fa added a commit that referenced this pull request Jan 30, 2023
@iknox-fa
Merge: #6773
92a32e6
iknox-fa added a commit that referenced this pull request Jan 31, 2023
@iknox-fa
Merge: #6773
9121f30
@nssalian nssalian deleted the ns/ct-1940-pythonmodule-postgrescolumn branch February 2, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 approved these changes

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt colin-rogers-dbt was automatically assigned from dbt-labs/adapters

@peterallenwebb peterallenwebb Awaiting requested review from peterallenwebb peterallenwebb was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1940] [Feature] Stand-alone Python module for PostgresColumn
2 participants
@nssalian @dbeatty10