Create method for env var deprecation #7086
Conversation
| DEPRECATED_PARAMS = { | ||
| "deprecated_print": "print", | ||
| } |
There was a problem hiding this comment.
Will the approach here be extensible to other deprecated/renamed flags & env vars? (#6903)
| @@ -97,6 +103,10 @@ def assign_params(ctx, params_assigned_from_default): | |||
| # when using frozen dataclasses. | |||
| # https://docs.python.org/3/library/dataclasses.html#frozen-instances | |||
| if hasattr(self, param_name.upper()): | |||
| if param_name in deprecated_env_vars: | |||
There was a problem hiding this comment.
Do we need to consider a case where people set both deprecated and and the new env var?
There was a problem hiding this comment.
This is that case. The warning message states that the deprecated env var will always be respected over the flag and if you want to respect the flag you should unset it.
| param_source = ctx.get_parameter_source(param_name) | ||
| if param_source == ParameterSource.DEFAULT: | ||
| continue | ||
| elif param_source != ParameterSource.ENVIRONMENT: |
There was a problem hiding this comment.
Is this actually possible since those params are already hidden?
There was a problem hiding this comment.
It shouldn't be but I'd rather be explicit about what should happen here.
stu-k
force-pushed
the
CT-2109/flag-param-renaming
branch
from
387b10d
to
663d8b8
Compare
There was a problem hiding this comment.
Hmm, should we implement DeprecatedOption as outlined in this Stack Overflow post: https://stackoverflow.com/a/50402799?
The only reservation I have with the current approach is that it unbundles deprecated options from non-deprecated ones, and we'd want to keep the two close?
|
@aranke That's a good idea, let me play around with that. |
|
@aranke The |
* ct-2198: clean up some type names and uses * CT-2198: Unify constraints and constraints_check properties on columns * Make mypy version consistently 0.981 (#7134) * CT 1808 diff based partial parsing (#6873) * model contracts on models materialized as views (#7120) * first pass * rename tests * fix failing test * changelog * fix functional test * Update core/dbt/parser/base.py * Update core/dbt/parser/schemas.py * Create method for env var deprecation (#7086) * update to allow adapters to change model name resolution in py models (#7115) * update to allow adapters to change model name resolution in py models * add changie * fix newline adds * move quoting into macro * use single quotes * add env DBT_PROJECT_DIR support #6078 (#6659) Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> * Add new index.html and changelog yaml files from dbt-docs (#7141) * Make version configs optional (#7060) * [CT-1584] New top level commands: interactive compile (#7008) Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> * CT-2198: Add changelog entry * CT-2198: Fix tests which broke after merge * CT-2198: Add explicit validation of constraint types w/ unit test * CT-2198: Move access property, per code review * CT-2198: Remove a redundant macro * CT-1298: Rework constraints to be adapter-generated in Python code * CT-2198: Clarify function name per review --------- Co-authored-by: Gerda Shank <gerda@dbtlabs.com> Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> Co-authored-by: Stu Kilgore <stu.kilgore@dbtlabs.com> Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com> Co-authored-by: Leo Schick <67712864+leo-schick@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: FishtownBuildBot <77737458+FishtownBuildBot@users.noreply.github.com> Co-authored-by: dave-connors-3 <73915542+dave-connors-3@users.noreply.github.com> Co-authored-by: Kshitij Aranke <kshitij.aranke@dbtlabs.com> Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>
resolves #6960
Description
AI PR summary: This pull request includes a wide range of changes to improve the functionality, maintainability, and documentation of the codebase. The most important changes include handling deprecated environment variables, adding a new
Notification::Cacheclass, and updating the version numbers and scripts in the documentation files.Added a method of warning about deprecated environment variables and implemented it for
DBT_NO_PRINT -> DBT_PRINT.Checklist
changie newto create a changelog entry