Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mypy version consistently 0.981 #7134

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Make mypy version consistently 0.981 #7134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e62db2c
Make mypy version consistently 0.981
gshank Mar 7, 2023
77e4ea9
Remove explicit installation of mypy and depend on dev-requirements.txt
gshank Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
python -m pip --version
python -m pip install pre-commit
pre-commit --version
python -m pip install mypy==0.942
python -m pip install mypy==0.981
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to do this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have no idea why it was there. Removed the pip install and moved the line checking mypy version after dev-requirements.

mypy --version
python -m pip install -r requirements.txt
python -m pip install -r dev-requirements.txt
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ repos:
alias: flake8-check
stages: [manual]
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.942
rev: v0.981
hooks:
- id: mypy
# N.B.: Mypy is... a bit fragile.
Expand Down