Deprecate more env vars #7175
Merged
Deprecate more env vars #7175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu-k
force-pushed
the
CT-2066/deprecate-old-env-vars
branch
from
8f51e7e to
a57266a
Compare
stu-k
commented
Mar 17, 2023
Comment on lines
+47
to
+60
| def assert_deprecated(self, logs_dir, old_env_var, new_env_var, command="run", old_val="0"): | ||
| os.environ[old_env_var] = old_val | ||
| run_dbt([command]) | ||
|
|
||
| # replacing new lines with spaces accounts for text wrapping | ||
| log_file = read_file(logs_dir, "dbt.log").replace("\n", " ").replace("\\n", " ") | ||
| dep_str = f"The environment variable `{old_env_var}` has been renamed as `{new_env_var}`" | ||
|
|
||
| try: | ||
| assert dep_str in log_file | ||
| except Exception as e: | ||
| del os.environ[old_env_var] | ||
| raise e | ||
| del os.environ[old_env_var] |
There was a problem hiding this comment.
I'm not so sure about how I handle setting/unsetting env vars here. I am welcome to other suggestions.
ChenyuLInx
reviewed
Mar 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6903
Description
Deprecate the rest of the environment variables outlined in the issue.
Checklist
changie newto create a changelog entry