-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update help text for commands + params in CLI and top-level API #7176
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
@dbeatty10 Is this nearly ready for review? Even if you didn't get 100% through all commands/params, I'd love to include what you've already got, before we cut v1.5.0-rc1 next week! |
I can put this up for review later today 👍 |
…t-core into dbeatty/6546-param-help-text
Love to see this, thanks @dbeatty10! |
resolves #6546
Description
See #6546 for description.
Removals
dbt parse --compile/--no-compile
dbt parse --write-manifest
dbt compile --parse-only
dbt show --parse-only
Additions
Added these three as synonyms per suggestion "12-factor CLI" and CLIG:
--version
-V
-v
Same thing here:
--quiet
-q
By explicitly attaching
-V
,-v
, and-q
to their most conventional uses, we can proactively prevent them from accidentally being attached in a non-conventional way.Help text reviewed
Reviewed the output of:
dbt build --help
dbt clean --help
dbt compile --help
dbt debug --help
dbt deps --help
dbt docs --help
dbt init --help
dbt list --help
dbt parse --help
dbt run --help
dbt run-operation --help
dbt seed --help
dbt snapshot --help
dbt source --help
dbt test --help
Testing
dbt debug --config-dir
doesn't appear in any functional testsSide notes
CLIG suggests:
--json
and--plain
to specify how output is rendered to standard out-o, --output
is to specify the path of the output fileHowever, we are using
--output json
and--output text
instead of--json
and--plain
in multiple sub-commands. The one exception isdbt source freshness --output PATH
which does accept an output file path.I'm not sure how much pain or annoyance any of this is causing though.
Checklist
I have opened an issue to add/update docs, ordocs changes are not required/relevant for this PRI have runchangie new
to create a changelog entrygit grep "TODO" core/dbt/cli/main.py
git grep "TODO" core/dbt/cli/params.py