Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: dbt show #7208

Merged
merged 32 commits into from
Apr 4, 2023
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e6dcca4
New command: dbt show
aranke Mar 22, 2023
f0ad043
merge main
aranke Mar 22, 2023
eab733f
merge main
aranke Mar 24, 2023
d726061
migrate classes to google proto
aranke Mar 24, 2023
bc09cd7
make proto_types
aranke Mar 24, 2023
f28af9c
fix test_events
aranke Mar 24, 2023
2bcb790
get most tests working
aranke Mar 24, 2023
e0db983
write couple tests for interactive preview
aranke Mar 24, 2023
45a7f1a
Merge branch 'main' into command_show
aranke Mar 24, 2023
3133d22
more fixing and refactoring
aranke Mar 24, 2023
09bec45
get everything except ephemeral models working
aranke Mar 24, 2023
e845b37
remove debug print
aranke Mar 24, 2023
ea6b2b0
fix test_events
aranke Mar 24, 2023
f25b44b
preview ephemeral nodes
aranke Mar 24, 2023
2ff263d
add changelog
aranke Mar 24, 2023
b3cc37d
fix style issue in requires.py
aranke Mar 24, 2023
9a6baa9
Address comments from Jerco
aranke Mar 28, 2023
3f36494
Restore core/dbt/cli/requires.py
Mar 28, 2023
f885193
Merge branch 'main' into command_show
aranke Mar 28, 2023
aac83b5
remove numbers from log
aranke Mar 28, 2023
ac008e0
test agate table for length
aranke Mar 28, 2023
5c96420
use table instead of limit_table
aranke Mar 28, 2023
ffc66bd
don't keep null in seed
aranke Mar 28, 2023
e20af84
remove flaky tests
aranke Mar 28, 2023
0bec7c4
don't test json formatting via string
aranke Mar 28, 2023
310ddf3
simplify show tests
aranke Mar 29, 2023
05fcd34
Fire events for excluded nodes
aranke Apr 4, 2023
b576018
merge from main
aranke Apr 4, 2023
c5d4f11
fix proto_types
aranke Apr 4, 2023
b1f29c1
rename: node -> result
aranke Apr 4, 2023
06fd124
fix if/else, log @ debug
aranke Apr 4, 2023
4309fac
fix args lookup
aranke Apr 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename: node -> result
aranke committed Apr 4, 2023
commit b1f29c1e473782a8fe98df81d225c4691a89e18f
10 changes: 5 additions & 5 deletions core/dbt/task/compile.py
Original file line number Diff line number Diff line change
@@ -67,11 +67,11 @@ def task_end_messages(self, results):
matched_results = [result for result in results if result.node.name == "inline_query"]
elif self.selection_arg:
matched_results = []
for node in results:
if node.node.name in self.selection_arg[0]:
matched_results.append(node)
if node not in matched_results:
fire_event(Note(msg=f"Excluded node '{node.node.name}' from results"))
for result in results:
if result.node.name in self.selection_arg[0]:
matched_results.append(result)
if result not in matched_results:
fire_event(Note(msg=f"Excluded node '{result.node.name}' from results"))
# No selector passed, compiling all nodes
else:
matched_results = []
10 changes: 5 additions & 5 deletions core/dbt/task/show.py
Original file line number Diff line number Diff line change
@@ -50,11 +50,11 @@ def task_end_messages(self, results):
matched_results = [result for result in results if result.node.name == "inline_query"]
else:
matched_results = []
for node in results:
if node.node.name in self.selection_arg[0]:
matched_results.append(node)
if node not in matched_results:
fire_event(Note(msg=f"Excluded node '{node.node.name}' from results"))
for result in results:
if result.node.name in self.selection_arg[0]:
matched_results.append(result)
if result not in matched_results:
fire_event(Note(msg=f"Excluded node '{result.node.name}' from results"))

for result in matched_results:
# Allow passing in -1 (or any negative number) to get all rows