compile inline query doesn't add node #7292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ChenyuLInx
force-pushed
the
cl/compile_query_work
branch
from
69fb6bf to
47b915d
Compare
ChenyuLInx
commented
Apr 6, 2023
core/dbt/task/compile.py
Outdated
| # it should be removed before the task is complete | ||
| _inline_node_id = None | ||
|
|
||
| # TODO remove when stu's PR about skip adapter cache is merged |
There was a problem hiding this comment.
As stated, this should be removed once Stu's work is done.
jtcohen6
reviewed
Apr 10, 2023
core/dbt/task/compile.py
Outdated
| # it should be removed before the task is complete | ||
| _inline_node_id = None | ||
|
|
||
| # TODO remove when stu's PR about skip adapter cache is merged |
|
|
||
| return runner.safe_run(manifest) | ||
|
|
||
|
|
||
| def parse_to_manifest(config): |
There was a problem hiding this comment.
If we implement #6547, we would be able to remove this method as well, right?
ChenyuLInx
force-pushed
the
cl/compile_query_work
branch
from
47b915d to
762a3f6
Compare
ChenyuLInx
changed the title
|
Closing due to git history looks odd, will reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6358
When compile a inline node, we add one additional node to the manifest. That node should be removed when compile is done.