compile inline query doesn't add node #7325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
|
@stu-k Once your PR is merged I will update this to point to main |
ChenyuLInx
commented
Apr 11, 2023
| @@ -1,10 +1,5 @@ | |||
| import os | |||
| from dbt.config.project import Project | |||
| from dbt.contracts.results import RunningStatus, collect_timing_info | |||
There was a problem hiding this comment.
This whole file is removed on main. The diff will disappear once removed
An error occurred while trying to automatically change base from
CT-1751/skip-relation-cache
to
main
April 11, 2023 18:15
ChenyuLInx
commented
Apr 11, 2023
| @@ -40,6 +40,10 @@ def compile(self, manifest): | |||
|
|
|||
|
|
|||
| class CompileTask(GraphRunnableTask): | |||
| # We add a new inline node to the manifest during initialization | |||
There was a problem hiding this comment.
This is the only change.
There was a problem hiding this comment.
Will have to add a test for it.
An error occurred while trying to automatically change base from
CT-1751/skip-relation-cache
to
main
April 11, 2023 18:15
An error occurred while trying to automatically change base from
CT-1751/skip-relation-cache
to
main
April 11, 2023 18:15
An error occurred while trying to automatically change base from
CT-1751/skip-relation-cache
to
main
April 11, 2023 18:15
stu-k
approved these changes
Apr 11, 2023
An error occurred while trying to automatically change base from
CT-1751/skip-relation-cache
to
main
April 11, 2023 18:18
An error occurred while trying to automatically change base from
CT-1751/skip-relation-cache
to
main
April 11, 2023 18:18
ChenyuLInx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6358
When compile a inline node, we add one additional node to the manifest. That node should be removed when compile is done.