compile inline query doesn't add node #7326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu-k
approved these changes
Apr 12, 2023
MichelleArk
reviewed
Apr 12, 2023
| def after_run(self, adapter, results): | ||
| # remove inline node from manifest | ||
| if self._inline_node_id: | ||
| self.manifest.nodes.pop(self._inline_node_id) |
There was a problem hiding this comment.
do we need to reset _inline_node_id as well?
There was a problem hiding this comment.
Good catch! I had it in some version then lost it due to some branch moving around.
Also added test!
MichelleArk
reviewed
Apr 12, 2023
| ["compile", "--inline", "select * from {{ ref('second_model') }}"], | ||
| populate_cache=False, | ||
| ) | ||
| assert len(manifest.nodes) == 4 |
stu-k
approved these changes
Apr 12, 2023
MichelleArk
reviewed
Apr 12, 2023
| @@ -40,6 +40,10 @@ def compile(self, manifest): | |||
|
|
|||
|
|
|||
| class CompileTask(GraphRunnableTask): | |||
| # We add a new inline node to the manifest during initialization | |||
| # it should be removed before the task is complete | |||
| _inline_node_id = None | |||
There was a problem hiding this comment.
It feels a bit off to have a non-constant, instance-specific representation state as a class attribute. Is there a reason this isn't defined on the instance instead via an __init__ override?
aranke
reviewed
Apr 12, 2023
There was a problem hiding this comment.
Should we abstract node creation/deletion into a context manager function decorator?
https://docs.python.org/3/library/contextlib.html#using-a-context-manager-as-a-function-decorator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6358
When compile a inline node, we add one additional node to the manifest. That node should be removed when compile is done.
I tried but couldn't find a way to add a test for this. was hoping to have one function to remove the line node and validate it is being called when running inline query but couldn't mock because dbt.task.compile is not a package.Didin't try hard enough last time, added test