fix for bug which continued to use master conn for on-run-end hooks #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cmcarthur we originally created this PR (#693) to fix some issues with
on-run-endhooks. These hooks previously used themasterconnection, and that led to a bunch of problems with statements and connection issues for long runs.While we thought our PR fixed this bug, an issue with our logic resulting in dbt using the
masterconnection anyway. This PR fixes that logic, and the code looks a little bit cleaner now too.Should we try to get this into our 0.10.1 release?