Display public models in output of list command #7816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selector_methods.py
MichelleArk
reviewed
Jun 7, 2023
peterallenwebb
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Should we consider having the PublicModel class inherit from GraphNode? I'm concerned that introducing a "node that isn't really a node" adds more complexity than we will want to manage. On the other hand, maybe the solution is to use the ManifestOrPublicNode protocol more widely, in which case I'd suggest renaming it to something more evocative.
Another lingering question: Aren't all nodes "graph nodes"? If they aren't, what do we mean by node?
I'm going to approve, since I think these changes do what they say on the tin and don't constrain our options going forward, but I'd be interested in your thoughts.
|
We're not doing it this way now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7496
Description
Add public models to the graph and the selection code to enable listing public models and using selection syntax for upstream nodes of public nodes.
Note: There's some noise in the selector_methods.py because I couldn't stand the non-standard node/real_node thing and switched it all to unique_id/node, which doesn't totally confuse people.
Checklist
changie newto create a changelog entry