Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loosen the click pin #8232

Merged
merged 5 commits into from
Jul 28, 2023
Merged

loosen the click pin #8232

merged 5 commits into from
Jul 28, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jul 27, 2023

resolves #8145
docs dbt-labs/docs.getdbt.com/#

Problem

click pin is too restrictive

Solution

pin
click<9

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@emmyoop emmyoop requested a review from a team as a code owner July 27, 2023 19:56
@emmyoop emmyoop requested review from aranke and VersusFacit and removed request for a team July 27, 2023 19:56
@cla-bot cla-bot bot added the cla:yes label Jul 27, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop requested a review from a team as a code owner July 27, 2023 19:57
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #8232 (41fedb6) into main (fe9c875) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8232   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files         174      174           
  Lines       25511    25511           
=======================================
+ Hits        21986    21987    +1     
+ Misses       3525     3524    -1     
Files Changed Coverage Δ
core/setup.py 0.00% <ø> (ø)
core/dbt/cli/params.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@emmyoop emmyoop changed the title loosen the click pin, add upper bound to sqlparse pin loosen the click pin Jul 27, 2023
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the reason we were pinning in the first place is removed so the change looks good to me

@emmyoop emmyoop merged commit 5b6d21d into main Jul 28, 2023
50 checks passed
@emmyoop emmyoop deleted the er/update-dependencies branch July 28, 2023 20:53
github-actions bot pushed a commit that referenced this pull request Jul 28, 2023
* loosen the click pin

* changelog

* separate out sqlparse pin

* remove changelog

* add ignores

(cherry picked from commit 5b6d21d)
@github-actions
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-8232-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5b6d21d7da00847e694111e21724a59053b36e76
# Push it to GitHub
git push --set-upstream origin backport-8232-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-8232-to-1.5.latest.

emmyoop added a commit that referenced this pull request Jul 28, 2023
* loosen the click pin

* changelog

* separate out sqlparse pin

* remove changelog

* add ignores
emmyoop added a commit that referenced this pull request Jul 28, 2023
* loosen the click pin

* changelog

* separate out sqlparse pin

* remove changelog

* add ignores

(cherry picked from commit 5b6d21d)

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
graciegoheen added a commit that referenced this pull request Aug 15, 2023
* loosen the click pin

* changelog

* separate out sqlparse pin

* remove changelog

* add ignores

Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2846] Update dependency pins: click<9 + sqlparse<0.5
2 participants