Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8022: Foreign key constraint on incremental model results in Database Error #8768

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Oct 4, 2023

resolves #8022

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4391dc1) 86.47% compared to head (b0668bf) 86.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8768      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.05%     
==========================================
  Files         176      176              
  Lines       26024    26024              
==========================================
- Hits        22505    22493      -12     
- Misses       3519     3531      +12     
Flag Coverage Δ
integration 83.23% <ø> (-0.12%) ⬇️
unit 64.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke marked this pull request as ready for review October 10, 2023 15:57
@aranke aranke requested review from a team as code owners October 10, 2023 15:57
@aranke aranke requested review from McKnight-42 and mikealfare and removed request for McKnight-42 October 10, 2023 15:57
@aranke aranke merged commit 6461f5a into main Oct 10, 2023
60 checks passed
@aranke aranke deleted the fix_8022 branch October 10, 2023 17:32
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants