Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put "this" var back into operation context #879

Merged
merged 2 commits into from
Jul 25, 2018
Merged

put "this" var back into operation context #879

merged 2 commits into from
Jul 25, 2018

Conversation

drewbanin
Copy link
Contributor

We had removed this context variable for operations in 0.10.2, but this represents a breaking change to the context. We should remove this eventually, but we should do it in a minor release.

@drewbanin drewbanin requested a review from cmcarthur July 25, 2018 14:09
@drewbanin
Copy link
Contributor Author

Note that this PR does not fix #878, but is motivated by it.

cmcarthur
cmcarthur approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@cmcarthur cmcarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@drewbanin drewbanin merged commit a2f8f48 into development Jul 25, 2018
@drewbanin drewbanin deleted the fix/readd-this-to-operation-context branch July 25, 2018 18:38
@beckjake beckjake mentioned this pull request Nov 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcarthur cmcarthur cmcarthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewbanin @cmcarthur