Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move deprecations to common #8907

Conversation

MichelleArk
Copy link
Contributor

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Oct 25, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbd02e5) 86.20% compared to head (507fa2b) 86.15%.
Report is 6 commits behind head on feature/decouple-adapters-from-core.

Additional details and impacted files
@@                           Coverage Diff                           @@
##           feature/decouple-adapters-from-core    #8907      +/-   ##
=======================================================================
- Coverage                                86.20%   86.15%   -0.06%     
=======================================================================
  Files                                      183      187       +4     
  Lines                                    26468    26505      +37     
=======================================================================
+ Hits                                     22818    22835      +17     
- Misses                                    3650     3670      +20     
Flag Coverage Δ
integration 82.95% <100.00%> (-0.11%) ⬇️
unit 64.49% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/adapters/base/impl.py 80.25% <100.00%> (ø)
core/dbt/adapters/base/meta.py 98.11% <100.00%> (ø)
core/dbt/cli/flags.py 92.18% <100.00%> (ø)
core/dbt/clients/registry.py 80.64% <100.00%> (ø)
core/dbt/common/deprecations.py 92.94% <ø> (ø)
core/dbt/config/project.py 97.41% <100.00%> (ø)
core/dbt/contracts/graph/unparsed.py 93.99% <100.00%> (ø)
core/dbt/task/clean.py 100.00% <100.00%> (ø)
core/dbt/task/deps.py 94.32% <100.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk marked this pull request as ready for review October 26, 2023 20:05
@MichelleArk MichelleArk requested review from a team as code owners October 26, 2023 20:05
@MichelleArk MichelleArk requested review from Fleid and gshank October 26, 2023 20:05
@MichelleArk
Copy link
Contributor Author

MichelleArk commented Nov 16, 2023

Closing in favor of: #9051

deprecations should remain in core because they make use of tracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants