Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9119: Get sources working again in dbt docs generate #9159

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

aranke
Copy link
Member

@aranke aranke commented Nov 28, 2023

resolves #9119

Problem

dbt docs generate doesn't write out sources

Solution

Modify dbt docs generate to write out sources

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@aranke aranke requested a review from a team as a code owner November 28, 2023 15:52
@cla-bot cla-bot bot added the cla:yes label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32fde75) 86.60% compared to head (201d75b) 86.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9159      +/-   ##
==========================================
- Coverage   86.60%   86.60%   -0.01%     
==========================================
  Files         179      179              
  Lines       26598    26600       +2     
==========================================
+ Hits        23036    23037       +1     
- Misses       3562     3563       +1     
Flag Coverage Δ
integration 83.47% <100.00%> (+0.02%) ⬆️
unit 65.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke
Copy link
Member Author

aranke commented Nov 28, 2023

@graciegoheen @jtcohen6

I've fixed the regression for #9119 in this PR so that I can proceed with releasing v1.7.3 tomorrow.

However, there is still an issue where selectors aren't working correctly for entities that are not models (confirmed behavior with seeds and sources).
I'm thinking of creating a backlog ticket to address this scenario, does that work?

@aranke aranke changed the title Fix #9119: Get sources working again in dbt docs generate Fix #9119: Get sources working again in dbt docs generate Nov 28, 2023
@aranke
Copy link
Member Author

aranke commented Nov 28, 2023

Created a backlog ticket to fix selectors in dbt docs generate more broadly: #9161

@graciegoheen
Copy link
Contributor

That works thanks @aranke

@aranke aranke merged commit c836b75 into main Nov 28, 2023
51 checks passed
@aranke aranke deleted the fix_9119 branch November 28, 2023 18:21
github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
@tallamohan
Copy link

Hay @aranke , When can we expect the next release with this fix?

@aranke
Copy link
Member Author

aranke commented Dec 4, 2023

@tallamohan It's part of the dbt-core 1.7.3 release!

https://github.com/dbt-labs/dbt-core/releases/tag/v1.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3406] catalog.json file does not contain sources
5 participants