spike unit test versions #9302
Draft
spike unit test versions #9302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
* WIP * remove breakpoint * fix tests, fix schema
* use unit test name as top level * remove breakpoints * finish converting tests * fix unit test node name * breakpoints * fix partial parsing bug * comment out duplicate test * fix test and make unique id match other uniqu id patterns * clean up * fix incremental test * Update tests/functional/unit_testing/test_unit_testing.py
* WIP * adding tests * fix tests * more tests * fix broken tests * fix broken tests * change to csv extension * fix unit test yaml * add mixed inline and file csv test * add mixed inline and file csv test * additional changes * read file directly * some cleanup and soem test fixes - wip * fix test * use better file searching * fix final test * cleanup * use absolute path and fix tests
* Add unit tests to state:modified selection * Get defer working too yolo * Refactor per marky suggestion * Add changelog * separate out unit test state tests + fix csv fixture tests * formatting * detect changes to fixture files with state:modified --------- Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
…-core into unit_testing_feature_branch
* Switch to using 'test' command instead of 'unit-test' * Remove old unit test * Put daff changes into task/test.py * changie * test_type:unit * Add unit test to build and make test * Select test_type:data * Add unit tets to test_graph_selector_methods.py * Fix fqn to incude path components * Update build test * Remove part of message in test_csv_fixtures.py that's different on Windows * Rename build test directory
* convert test to data_test * generate proto types * fixing tests * add tests * add more tests * test cleanup * WIP * fix graph * fix testing manifest * set resource type back to test and reset unique id * reset expected run results * cleanup * changie * modify to only look for tests under columns in schema files * stop using dashes
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## unit_testing_feature_branch #9302 +/- ##
===============================================================
- Coverage 86.88% 80.26% -6.62%
===============================================================
Files 223 223
Lines 27657 27865 +208
===============================================================
- Hits 24029 22367 -1662
- Misses 3628 5498 +1870
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gshank
force-pushed
the
unit_testing_feature_branch
branch
from
5e98353
to
8fbbb65
Compare
gshank
force-pushed
the
unit_testing_feature_branch
branch
from
8fbbb65
to
56dfb34
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8799
Problem
Unit tests do not account for model versions.
Solution
Add functionality to
Since the model versions are defined in the schema files we don't have this until the end of parsing. We need to patch unit tests to be able to determine what versions of the model needs to be unit tested.
This PR is a first pass at that. It fails in partial parsing because the unique ids have been modified to include the model version but when we're partial parsing we don't know the versions yet so it doesn't recognize them. When the model names is changed, it currently continues to run the old unit test and just adds a new unit test with a new name.
Checklist