Move the contents of dbt.contracts.results to a new dbt.artifacts directory #9350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9350 +/- ##
==========================================
+ Coverage 86.59% 86.62% +0.02%
==========================================
Files 225 230 +5
Lines 27024 27059 +35
==========================================
+ Hits 23402 23440 +38
+ Misses 3622 3619 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gshank
changed the title
emmyoop
pushed a commit
that referenced
this pull request
Jan 12, 2024
emmyoop
pushed a commit
that referenced
this pull request
Jan 12, 2024
emmyoop
added a commit
that referenced
this pull request
Jan 16, 2024
* replace dbt/common with dbt-common * update requirements, remove colorama * remove dbt-common unit tests * WIP * some cleanup * update imports from dbt.common to dbt_common * remove tests/unit/common * changelog entry * remove commented out code * move cache exceptions to dbt/adapters (#9361) * point to dbt-common main * Move the contents of dbt.contracts.results to a new dbt.artifacts directory (#9350) * conflict resolution cleanup * cleanup * add ignoreb --------- Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com> Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9193
resolves #9200
Problem
With the goal of eventually having a separate dbt artifacts package, move the result artifacts into a new dbt/artifacts directory.
Solution
Split up the contents of core/dbt/contracts/results.py into various files in dbt/artifacts -- base.py, results.py, freshness.py, run.py and catalog.py.
For temporary use while in the middle of this conversion, core/dbt/contracts/results.py has been turned into a file that imports the various classes from dbt/artifacts.
Checklist