-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow Housekeeping #9428
Workflow Housekeeping #9428
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9428 +/- ##
==========================================
+ Coverage 86.96% 86.98% +0.01%
==========================================
Files 187 187
Lines 25014 25014
==========================================
+ Hits 21754 21759 +5
+ Misses 3260 3255 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- label: "snyk" | ||
changie_kind: "Security" | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use snyk anymore
@@ -19,6 +19,8 @@ name: Check Changelog Entry | |||
on: | |||
pull_request_target: | |||
types: [opened, reopened, labeled, unlabeled, synchronize] | |||
paths-ignore: ['.changes/**', '.github/**', 'tests/**', '**.md', '**.yml'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are the only fields changing, there does not need to be a changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now done as part of the release. It's not a separate step. The workflow lives in actions
still as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for cleaning this up!
resolves #9432
Problem
Solution
Checklist