Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Housekeeping #9428

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Workflow Housekeeping #9428

merged 1 commit into from
Jan 24, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 23, 2024

resolves #9432

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 23, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af18862) 86.96% compared to head (db39c1b) 86.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9428      +/-   ##
==========================================
+ Coverage   86.96%   86.98%   +0.01%     
==========================================
  Files         187      187              
  Lines       25014    25014              
==========================================
+ Hits        21754    21759       +5     
+ Misses       3260     3255       -5     
Flag Coverage Δ
integration 84.37% <ø> (+0.01%) ⬆️
unit 63.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jan 23, 2024
- label: "snyk"
changie_kind: "Security"
runs-on: ubuntu-latest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use snyk anymore

@@ -19,6 +19,8 @@ name: Check Changelog Entry
on:
pull_request_target:
types: [opened, reopened, labeled, unlabeled, synchronize]
paths-ignore: ['.changes/**', '.github/**', 'tests/**', '**.md', '**.yml']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are the only fields changing, there does not need to be a changelog

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now done as part of the release. It's not a separate step. The workflow lives in actions still as well.

@emmyoop emmyoop marked this pull request as ready for review January 23, 2024 20:04
@emmyoop emmyoop requested a review from a team as a code owner January 23, 2024 20:04
@emmyoop emmyoop requested a review from aranke January 23, 2024 20:04
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for cleaning this up!

@emmyoop emmyoop merged commit 07c40d6 into main Jan 24, 2024
57 of 59 checks passed
@emmyoop emmyoop deleted the er/workflow-cleanup branch January 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up workflows
2 participants