Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Exposure data parts to dbt/artifacts #9494

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Jan 31, 2024

resolves #9380

Problem

We are moving data artifacts to dbt/artifacts in a piecewise fashion. We needed to move Exposure as part of that.

Solution

Moved data portion of Exposure to dbt/artifacts (and all other classes that doing so required)

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 31, 2024
@QMalcolm QMalcolm changed the base branch from main to qmalcolm--9387-move-semantic-model-to-dbt-artifacts January 31, 2024 00:49
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0836095) 87.97% compared to head (5a9145a) 88.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9494      +/-   ##
==========================================
+ Coverage   87.97%   88.01%   +0.04%     
==========================================
  Files         166      167       +1     
  Lines       22119    22130      +11     
==========================================
+ Hits        19459    19478      +19     
+ Misses       2660     2652       -8     
Flag Coverage Δ
integration 85.56% <100.00%> (+0.12%) ⬆️
unit 62.36% <97.67%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QMalcolm QMalcolm force-pushed the qmalcolm--9380-move-exposure-to-dbt-artifacts branch 3 times, most recently from cb309c4 to b8725ca Compare February 1, 2024 00:28
@QMalcolm QMalcolm marked this pull request as ready for review February 1, 2024 00:30
@QMalcolm QMalcolm requested a review from a team as a code owner February 1, 2024 00:30
@QMalcolm QMalcolm requested a review from emmyoop February 1, 2024 00:30
Copy link
Contributor

@MichelleArk MichelleArk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

Base automatically changed from qmalcolm--9387-move-semantic-model-to-dbt-artifacts to main February 1, 2024 00:50
@QMalcolm
Copy link
Contributor Author

QMalcolm commented Feb 1, 2024

The branch for this PR was based off of the branch qmalcolm--9387-move-semantic-model-to-dbt-artifacts (now deleted) which was the branch for the PR #9485. Because we only allow for squash merges, the commits from the branch qmalcolm--9387-move-semantic-model-to-dbt-artifacts don't exist on main, but instead a single commit exists with all the contents. Thus this PR now has merge conflicts 😞 So I'm now going to rebase this branch off of main (which will make it look like the approval came before the work was done, but that's not actually the case).

There were a few places in the code base that were importing `Owner`
from `unparsed` or `nodes`. The places importing from `unparsed` were
working because `unparsed` itself was correctly importing from
`artifacts.resources`. However in places where it was being imported
from `nodes`, an exception was being raised because in the previous
commit we removed the import of `Owner` in `nodes` because it was
no longer needed.
@QMalcolm QMalcolm force-pushed the qmalcolm--9380-move-exposure-to-dbt-artifacts branch from b8725ca to 5a9145a Compare February 1, 2024 01:05
@QMalcolm QMalcolm merged commit 2d59a51 into main Feb 1, 2024
51 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--9380-move-exposure-to-dbt-artifacts branch February 1, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3550] Define Exposure contract in dbt/artifacts
2 participants