Fix error with validation code (#956) #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
Aug 28, 2018
cmcarthur
approved these changes
Aug 28, 2018
| def test_var_defined_is_missing(self): | ||
| var = Var(self.model, self.context, overrides={}) | ||
| var.assert_var_defined('foo', 'bar') | ||
| with self.assertRaises(dbt.exceptions.CompilationException): |
There was a problem hiding this comment.
this was raising AttributeError before, right?
There was a problem hiding this comment.
Yup. I reverted the fix commit and ran the test, and it fails with an AttributeError.
beckjake
force-pushed
the
var-validate-model-name
branch
2 times, most recently
from
f3ce094 to
50efa65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already set the model's name properly inside the class's
__init__, so we don't need to figure it out again, we can just use that.