Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flags & tracking from dbt/artifacts #9628

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 22, 2024

resolves #9390

Problem

dbt.tracking and dbt.flags from dbt/artifacts/schemas/manifest.py represent a dependency on dbt internals from an upstream component, meaning we could never package it separately.

Solution

Use global values instead of replying on post_init. Fix tests to account for new pattern.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Feb 22, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (7df747a) to head (daf4c49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9628      +/-   ##
==========================================
- Coverage   88.00%   87.98%   -0.02%     
==========================================
  Files         176      176              
  Lines       22311    22309       -2     
==========================================
- Hits        19634    19628       -6     
- Misses       2677     2681       +4     
Flag Coverage Δ
integration 85.57% <100.00%> (-0.02%) ⬇️
unit 62.10% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Feb 22, 2024
@emmyoop emmyoop marked this pull request as ready for review February 22, 2024 19:00
@emmyoop emmyoop requested a review from a team as a code owner February 22, 2024 19:00
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@emmyoop emmyoop merged commit 9a32716 into main Feb 23, 2024
63 of 64 checks passed
@emmyoop emmyoop deleted the er/9390-remove-flags-tracking branch February 23, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3560] Remove usage of flags and tracking in WritableManifest
2 participants