-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigquery clustering columns (#918) #978
Conversation
looks ok to me, @drewbanin can you take a look? |
{% endif %} | ||
|
||
{% set cluster_by_clause %} | ||
cluster by {{ raw_cluster_by }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is supposed to be a CSV of column names. That means that folks would do something like
{{
config(
materialized='table',
cluster_by='field_1, field_2'
)
}}
I think that's reasonable, but we accept an actual list
of values in other similar configs: https://github.com/fishtown-analytics/dbt/blob/development/dbt/include/global_project/macros/adapters/redshift.sql#L21
all things being equal, I think it would be good to keep this interface with other configs like this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when the tests pass
Add clustering support to bigquery adapter, include it in the stats output, add tests.
Fixes #918.