CT-50 Search results not filtering correctly #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed breaking null comlumn names also cleaned up a bunch of comments fix length bug on load removed debugging code add changelog and remove unnecesary code from debugging added changelog
emmyoop
force-pushed
the
er/ct-50-filtering
branch
from
4a01b52
to
15ace14
Compare
4 tasks
leahwicz
reviewed
Feb 24, 2022
leahwicz
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #236
Description
Search results not filtering correctly. This is actually a bug in dbt-spark. This fix makes it so docs continue to work by checking for conditions that should never be true.
This way, once the bug is fixed, docs will continue to work as expected and will continue to work for all other adapters.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.