Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle rename of metric attributes in sample SQL #346

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Handle rename of metric attributes in sample SQL #346

merged 4 commits into from
Nov 16, 2022

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Nov 16, 2022 •
edited
Loading

resolves #323

Description

Before

Screenshot 2022-11-16 at 15 50 29

After

Screenshot 2022-11-16 at 15 51 25

Derived metrics

I also updated the ci-project to use v1.3, and added a derived metric. This is what we show for those:
Screenshot 2022-11-16 at 15 53 53

Checklist

@cla-bot cla-bot bot added the cla:yes label Nov 16, 2022
@jtcohen6
Copy link
Contributor Author

After merging, this will want to be:

  • distributed to dbt-core repo
  • backported to 1.3.latest within dbt-core, for inclusion in v1.3.1

@jtcohen6 jtcohen6 merged commit ac6670c into main Nov 16, 2022
@jtcohen6 jtcohen6 deleted the fix/323-metric-attr-rename branch November 16, 2022 15:17
@jtcohen6 jtcohen6 mentioned this pull request Nov 16, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahwicz leahwicz leahwicz approved these changes

@stu-k stu-k Awaiting requested review from stu-k

@emmyoop emmyoop Awaiting requested review from emmyoop

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1352] Metric SQL generation breaks with dbt-core 1.3.0
2 participants
@jtcohen6 @leahwicz