Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove moved changie yml files #491

Closed
wants to merge 4 commits into from
Closed

Remove moved changie yml files #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c47caa
Attempt to update to handle unit tests
gshank Feb 27, 2024
e2398e2
Merge branch 'main' into gs/display_unit_tests
gshank Feb 28, 2024
fc54238
Fix unmatched quote
gshank Feb 28, 2024
20569b2
Delete changie files that were moved to dbt-core for release
FishtownBuildBot Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .changes/unreleased/Docs-20230615-105157.yaml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/app/components/column_details/column_details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<th style="background-color: white; position: sticky; top: 0; z-index: 1;">Type</th>
<th style="background-color: white; position: sticky; top: 0; z-index: 1;">Description</th>
<th style="width: 1px; background-color: white; position: sticky; top: 0; z-index: 1;">Constraints</th>
<th style="width: 1px; background-color: white; position: sticky; top: 0; z-index: 1;">Tests</th>
<th style="width: 1px; background-color: white; position: sticky; top: 0; z-index: 1;">Data Tests</th>
<th style="width: 1px; background-color: white; position: sticky; top: 0; z-index: 1;" class='text-center'>More?</th>
</tr>
</thead>
Expand Down Expand Up @@ -104,7 +104,7 @@ <h5>Constraints</h5>
</div>

<div ng-show="column.tests && column.tests.length" style="margin-bottom: 15px">
<h5>Generic Tests</h5>
<h5>Generic Data Tests</h5>
<ul class="list-unstyled" style="margin-top: 2px">
<li ng-repeat="test in column.tests" ng-switch on="test.short" class='text-light'>
<span ng-switch-when="F">
Expand Down
4 changes: 3 additions & 1 deletion src/app/components/references/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ angular
} else if (type == 'seed') {
return 'Seeds';
} else if (type == 'test') {
return 'Tests';
return 'Data Tests';
} else if (type == 'unit_test') {
return 'Unit Tests';
} else if (type == 'snapshot') {
return 'Snapshots'
} else if (type == 'analysis') {
Expand Down
9 changes: 9 additions & 0 deletions src/app/index.routes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const templates = {
snapshot: require('./docs/snapshot.html'),
seed: require('./docs/seed.html'),
test: require('./docs/test.html'),
unit_test: require('./docs/test.html'),
analysis: require('./docs/analysis.html'),
macro: require('./docs/macro.html'),
exposure: require('./docs/exposure.html'),
Expand Down Expand Up @@ -86,6 +87,14 @@ angular
unique_id: {type: 'string'}
},
})
.state('dbt.unit_test', {
url: 'unit_test/:unique_id?section&' + graph_params,
controller: 'TestCtrl',
templateUrl: templates.test,
params: {
unique_id: {type: 'string'}
},
})
.state('dbt.analysis', {
url: 'analysis/:unique_id?section&' + graph_params,
controller: 'AnalysisCtrl',
Expand Down
5 changes: 3 additions & 2 deletions src/app/services/node_selection_service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ angular
'snapshot',
'source',
'test',
'unit_test',
'analysis',
'exposure',
'metric',
Expand All @@ -37,7 +38,7 @@ angular
options: {
packages: [],
tags: [null],
resource_types: ['model', 'seed', 'snapshot', 'source', 'test', 'analysis', 'exposure', 'metric', 'semantic_model'],
resource_types: ['model', 'seed', 'snapshot', 'source', 'test', 'analysis', 'exposure', 'metric', 'semantic_model', 'unit_test'],
}
};

Expand All @@ -63,7 +64,7 @@ angular
include_selection = '+metric:' + node.name;
} else if (node && node.resource_type == 'semantic_model') {
include_selection = '+semantic_model:' + node.name;
} else if (node && _.includes(['analysis', 'test'], node.resource_type)) {
} else if (node && _.includes(['analysis', 'test', 'unit_test'], node.resource_type)) {
include_selection = '+' + node.name;
} else {
include_selection = "";
Expand Down
6 changes: 6 additions & 0 deletions src/app/services/project_service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,12 @@ angular
node.label = node.name;
});

// Add unit tests into nodes
_.each(service.files.manifest.unit_tests, function(node) {
service.files.manifest.nodes[node.unique_id] = node;
node.label = node.name;
});

var adapter = service.files.manifest.metadata.adapter_type;
var macros = clean_project_macros(service.files.manifest.macros, adapter);
service.files.manifest.macros = macros;
Expand Down
Loading