Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to dbt docs #496

Closed

Conversation

github-actions[bot]
Copy link
Contributor

Auto generated changes from generate-docs-for-dbt-core.yml workflow

@github-actions github-actions bot added the Skip Changelog Skips GHA to check for changelog file label Feb 29, 2024
@cla-bot cla-bot bot added the cla:yes label Feb 29, 2024
@graciegoheen graciegoheen changed the title Remove moved changie yml files Add unit tests to dbt docs Mar 1, 2024
@graciegoheen
Copy link

I like the new toggle under Referenced by for unit tests!
Screenshot 2024-03-01 at 10 28 05 AM

When I click into unit test page, I see a blank section for the code:
Screenshot 2024-03-01 at 10 28 27 AM

Can we eliminate this section entirely? Or we could put in the YML for the test definition and the compiled code if we have access to it. Either way is fine with. me!

@gshank
Copy link
Contributor

gshank commented Mar 1, 2024

I did eliminate that section completely. However it seemed to hang around for me afterward for some reason too, but then I refreshed something and it went away. Which branch did you use to test?

@gshank
Copy link
Contributor

gshank commented Mar 1, 2024

I tried again and it does seem to be using the wrong page. Randomly.

@gshank
Copy link
Contributor

gshank commented Mar 1, 2024

Okay, it should be working now. I needed to specify the unit_test template someplace

@gshank gshank requested a review from emmyoop March 1, 2024 21:09
@dbeatty10
Copy link
Contributor

There were some small conflicts. I just resolved them now.

@gshank gshank closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants