Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

( •́ _ •̀) Make saved query work in docs #510

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented May 17, 2024

resolves #486
It also need dbt-labs/dbt-core#10168

Description

This PR followed PR from Emily (Thanks!) to add support of saved query node.
TBH I don't really know what I wrote and most of the stuff probably can be better refactored into a function, but I don't really know this language so leaving a little bit headache for the future us.
You can tell how I feel by the commit but hey it works.

Screenshot 2024-05-16 at 10 26 38 PM Screenshot 2024-05-16 at 10 27 15 PM

Checklist

@cla-bot cla-bot bot added the cla:yes label May 17, 2024
@ChenyuLInx
Copy link
Contributor Author

Also added the color as @dbeatty10 's illustration!

@dbeatty10
Copy link
Contributor

🚀

@ChenyuLInx ChenyuLInx requested a review from emmyoop May 20, 2024 21:46
@ChenyuLInx ChenyuLInx merged commit b204005 into main May 21, 2024
12 checks passed
@ChenyuLInx ChenyuLInx deleted the cl/fix-saved-query branch May 21, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3530] Presence of saved_queries breaks lineage viz
3 participants