Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tags to docs view, dag view filters #7

Merged
merged 3 commits into from
Oct 30, 2018
Merged

add tags to docs view, dag view filters #7

merged 3 commits into from
Oct 30, 2018

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Oct 20, 2018

Closes #6

This PR replaces the node_type filter with tags, as there isn't generally a need to filter by node types in the graph viz.

I needed to re-implement some more of the dbt graph selection code in JS -- I think we'll need to figure out better ways of doing this if/when graph selection gets more complex.

Relevant tags PR: dbt-labs/dbt-core#1014

Test:

  • model view shows tags for a model, or None
  • DAG view is filterable by tags in a dropdown filter
  • --models and --exclude accept tag: and fqn: filter strings
  • dropdown tag filters play nice with fqn/tag selection using --models and --exclude

@drewbanin
Copy link
Contributor Author

Screenshots!

screen shot 2018-10-24 at 10 59 00 pm

screen shot 2018-10-24 at 10 59 07 pm

screen shot 2018-10-24 at 10 59 26 pm

screen shot 2018-10-24 at 10 59 42 pm

@drewbanin drewbanin requested a review from cmcarthur October 25, 2018 03:02
@cmcarthur
Copy link
Member

@drewbanin hey sorry I missed this. can you throw a class="meta" or <em> on untagged to differentiate it? then 👍

@drewbanin drewbanin merged commit 35d093d into master Oct 30, 2018
@drewbanin drewbanin deleted the add-tags branch October 30, 2018 14:57
amirbtb referenced this pull request in brocolidata/dbt-docs Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants