Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] fix tests for #308 #321

Merged
merged 8 commits into from
Oct 28, 2024
Merged

[HOTFIX] fix tests for #308 #321

merged 8 commits into from
Oct 28, 2024

Conversation

dataders
Copy link
Collaborator

Description & motivation

#308 introduced two issues that weren't caught until after merge:

  • ignore_case was always used for the infer_schema pre-fetch even if it wasn't defined
  • the integration test didn't correctly test the functionality

accordingly I:

  • made ignore_case true by default (thanks @robby-rob-slalom!)
  • created and uploaded the the S3 bucket a new set of parquet files (Jupyter notebook included)
  • updated the tests

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added an integration test for my fix/feature (if applicable)

@wiz-inc-266a8a9c32
Copy link

wiz-inc-266a8a9c32 bot commented Oct 28, 2024

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 0 0 0 0 0
Vulnerabilities 0 0 0 0 0 0
Sensitive Data 0 1 0 0 0 1
Secrets 0 0 0 0 0 0
Total 0 1 0 0 0 1

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Copy link
Collaborator Author

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm merging this bc i have zero clue why integration tests are failing when they work locally

@dataders dataders merged commit 241cd44 into main Oct 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant