Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added +full_refresh to model_configs #132

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Added +full_refresh to model_configs #132

merged 2 commits into from
Apr 8, 2024

Conversation

StuartMiddleton
Copy link
Contributor

fixes #131

joellabes

This comment was marked as outdated.

Sign in to view

joellabes
joellabes requested changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Can you also add the plussless version of full_refresh?

@StuartMiddleton
Copy link
Contributor Author

plussless version of full_refresh added and run sort JSON objects (which fixed a bunch of issues unrelated to my change).

@joellabes joellabes merged commit ed704c5 into dbt-labs:main Apr 8, 2024
25 checks passed
@joellabes
Copy link
Collaborator

Amazing tysm @StuartMiddleton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

+full_refresh property missing from model_configs
2 participants
@StuartMiddleton @joellabes