Model contract configs #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 49a64d4.
joellabes
requested changes
Mar 30, 2023
schemas/dbt_project.json
Outdated
Comment on lines
257
to
259
| "+contract": { | ||
| "$ref": "#/$defs/boolean_or_jinja_string" | ||
| }, |
There was a problem hiding this comment.
contract is an object now, containing a single bool enforced (dbt-labs/dbt-core#7184, dbt-labs/dbt-core#7222)
There was a problem hiding this comment.
yep, this should be deleted. Per the tests in that second PR the contract object is nested in config and i added it to the model_config block down below
There was a problem hiding this comment.
oh this is in the project yml file! will update!
joellabes
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configs for the upcoming 1.5 dbt core concepts for model contracts
you can:
For projects:
_resource.ymlfiles.For models
access- whether the model is public/private/protectedcontract- whether the model is subject to a model contractgroup- assign a model to a groupFor columns:
constraint- add a database constraint to the modelconstraint_checkadd a SQL check on the columnFor metrics:
groupsinconfig-- sneaking in a config object, as metrics will be able to be grouped -- adding the other two metric configs while I was in there (can split this out if we'd prefer to sequence these more thoughtfully)