Revamp incremental by period and make it work for BQ #42
Conversation
| -- finally, drop the existing/backup relation after the commit | ||
| {# {{ drop_relation_if_exists(backup_relation) }} #} |
There was a problem hiding this comment.
Is this meant to be commented out?
There was a problem hiding this comment.
Yes, I can remove it entirely. This comes from the OG table materialization but we don't define backup_relation anywhere in this one.
There was a problem hiding this comment.
Per discussion (primary here):
I didn't personally check how this behaves in dbt-bigquery with different datetime / timestamp fields or different time zone settings.
But approving in the sprit of "experimental features" "not intended as ready-to-use packages".
On that note, here's something we should probably add to the README:
Tip
We recommend clone and install as a local package, or just copy-paste.
But if you choose to ignore that recommendation and use subdirectory within packages.yml to install directly from this repo instead:
To avoid breaking behavior changes affecting your dbt project, you'll probably want to
specify a 40-character hash as the revision in addition to configuring the subdirectory. That way, you won't accidentally receive breaking changes.
insert_by_periodmaterializationPostgres:
Snowflake:
BQ:
