Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escape_single_quotes shim to spark adapter #269

Closed
graciegoheen opened this issue Dec 20, 2022 · 5 comments
Closed

Add escape_single_quotes shim to spark adapter #269

graciegoheen opened this issue Dec 20, 2022 · 5 comments

Comments

@graciegoheen
Copy link
Collaborator

    This should eventually be added to the spark adapter!

Originally posted by @graciegoheen in #246 (comment)

@graciegoheen
Copy link
Collaborator Author

PR has been opened in dbt-spark dbt-labs/dbt-spark#573

@dbeatty10
Copy link
Contributor

dbt-labs/dbt-spark#573 has been merged 🎉 and it is listed in the changelog here.

What would be the trade-offs of removing this file?

@dave-connors-3
Copy link
Collaborator

@dbeatty10 I think there would be limited issues! We'd need to make sure to also update the required dbt version once that's released into the wild to ensure users of this package use 1.4 and above

@dbeatty10
Copy link
Contributor

Cool! Timing and strategy up to y'all, of course.

@dbeatty10
Copy link
Contributor

@dbeatty10 I think there would be limited issues! We'd need to make sure to also update the required dbt version once that's released into the wild to ensure users of this package use 1.4 and above

I just updated the "implementation hints" here to reflect bumping up to 1.4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants