Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add escape_single_quotes macro #573

Merged
merged 5 commits into from
Jan 11, 2023
Merged

add escape_single_quotes macro #573

merged 5 commits into from
Jan 11, 2023

Conversation

graciegoheen
Copy link
Contributor

@graciegoheen graciegoheen commented Dec 21, 2022 •
edited
Loading

resolves #572

Description

Add escape_single_quotes macro for databricks/spark

Checklist

Which CLA do I need to sign?

@cla-bot
Copy link

cla-bot bot commented Dec 21, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @graciegoheen

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@cla-bot
Copy link

cla-bot bot commented Dec 21, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @graciegoheen

@graciegoheen graciegoheen mentioned this pull request Dec 21, 2022
Closed
@jtcohen6 jtcohen6 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Jan 5, 2023
@cla-bot
Copy link

cla-bot bot commented Jan 10, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @graciegoheen

@cla-bot
Copy link

cla-bot bot commented Jan 10, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @graciegoheen

@cla-bot
Copy link

cla-bot bot commented Jan 10, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @graciegoheen

@cla-bot cla-bot bot removed the cla:yes label Jan 10, 2023
@dbeatty10 dbeatty10 mentioned this pull request Jan 10, 2023
Closed
@colin-rogers-dbt colin-rogers-dbt merged commit 28a9d09 into main Jan 11, 2023
@colin-rogers-dbt colin-rogers-dbt deleted the fix/add_escape_single_quotes_macro branch January 11, 2023 00:09
@ueshin ueshin mentioned this pull request Jan 12, 2023
Merged
ueshin added a commit to databricks/dbt-databricks that referenced this pull request Jan 12, 2023
@ueshin
Follow up on adding escape_single_quotes macro. (#252)
4b56862 
### Description

Follows up on adding `escape_single_quotes` macro.

- dbt-labs/dbt-spark#573
@dbeatty10 dbeatty10 mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@joellabes joellabes Awaiting requested review from joellabes

@b-per b-per Awaiting requested review from b-per

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1701] [CT-1700] [Bug] escape_single_quotes is not correct for Spark/Databricks
4 participants
@graciegoheen @colin-rogers-dbt @jtcohen6 @dbeatty10