Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escape single quotes macro #586

Closed
wants to merge 8 commits into from

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jan 10, 2023

@cla-bot cla-bot bot added the cla:yes label Jan 10, 2023
@dbeatty10
Copy link
Contributor Author

dbeatty10 commented Jan 10, 2023

The test failed as desired here when removing the bugfix (via bf4306f):

=========================== short test summary info ============================
FAILED tests/functional/adapter/utils/test_utils.py::TestEscapeSingleQuotes::test_build_assert_equal - AssertionError: dbt exit state did not match expected
======= 1 failed, 41 passed, 25 skipped, 6 warnings in 116.73s (0:01:56) =======

@dbeatty10
Copy link
Contributor Author

Closing since it was only meant to validate that dbt-labs/dbt-core#6567 would have discovered the issue fixed by #573

@dbeatty10 dbeatty10 closed this Jan 11, 2023
@mikealfare mikealfare deleted the dbeatty/add_escape_single_quotes_macro branch March 1, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants