Lift + shift for cross-db macros #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This was referenced Jun 2, 2022
jtcohen6
reviewed
Jun 16, 2022
dev_requirements.txt
Outdated
Comment on lines
3
to
5
| git+https://github.com/dbt-labs/dbt-core.git@dbeatty/utils-lift-shift#egg=dbt-core&subdirectory=core | ||
| git+https://github.com/dbt-labs/dbt-core.git@dbeatty/utils-lift-shift#egg=dbt-tests-adapter&subdirectory=tests/adapter | ||
| git+https://github.com/dbt-labs/dbt-core.git@dbeatty/utils-lift-shift#egg=dbt-postgres&subdirectory=plugins/postgres |
There was a problem hiding this comment.
just need to remove the branch identifiers, rerun tests, then we should be hot to trot
jtcohen6
approved these changes
Jun 17, 2022
abbywh
pushed a commit
to abbywh/dbt-redshift
that referenced
this pull request
Oct 11, 2023
* Initialize lift + shift, dateadd + datediff * Switch to alternative dev branches * Lift and shift cross-database macros from dbt-utils * Switch namespace from `dbt_utils` to `dbt` * Remove conflicting definition of current_timestamp() * Trim trailing whitespace * Copy functional tests for cross-database macros from dbt-utils * Remove references to other profiles * Kick out the `current_timestamp` + `type_*` macros/tests * Specify the namespace explicitly * Duplicate default implementations into Redshift (to avoid inheritance issues) * Remove branch identifiers Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to dbt-labs/dbt-core#5265. Continues #119.
To do before merge
dev_requirements.txtback to originaldbt_utils.current_timestamp()before and after@pytest.mark.skip