Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt Constraints / model contracts #229

Merged
merged 33 commits into from
Feb 16, 2023
Merged

dbt Constraints / model contracts #229

merged 33 commits into from
Feb 16, 2023

Conversation

dave-connors-3
Copy link
Contributor

@dave-connors-3 dave-connors-3 commented Dec 7, 2022

resolves #227

Description

This PR is a WIP, and adds the constraints behavior to the redshift adapter

Related Core/Adapter Pull Requests

Must be reviewed with passing tests

Checklist

@cla-bot cla-bot bot added the cla:yes label Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@dbeatty10 dbeatty10 changed the title add constraints to Redshift adapter dbt Constraints / model contracts Feb 14, 2023
@jtcohen6 jtcohen6 merged commit 2c3f782 into main Feb 16, 2023
@jtcohen6 jtcohen6 deleted the dbt-constraints-redshift branch February 16, 2023 15:15
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
* redshift__get_columns_spec_ddl with just column names

* create and insert option

* fix check warning

* extend postgres adapter tests

* do not extend

* pin core branch for pytest

* changie entry

* reverse conditional statement, add explicit transactions

* add column name to log output, control whitespace

* add DDL test, some whitespace control

* ran precommit, samll edit to spacing on DDL

* update datatype to match DDL

* dynamic database name

* add test for attempting to insert a null

* update commands to be more specific in existing tests

* update check to constraints_check

* update project yml setting

* add column check

* remove redundant if statement

* fix code formatting check

* update redshift tests

* Small cleanup

* Reset to dbt-core main

---------

Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

[CT-1613] Update redshift adapter to use constraints and checks
4 participants