Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert incremental on_schema_change tests #269

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jan 14, 2023

See dbt-labs/dbt-core#6618

The copy-pasted tests had not been updated since fall 2021. They are functionally equivalent to the converted "adapter zone" test that we can now inherit.

Checklist

@jtcohen6 jtcohen6 added the Skip Changelog Skips GHA to check for changelog file label Jan 14, 2023
@cla-bot cla-bot bot added the cla:yes label Jan 14, 2023
dev-requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems ready to merge after core PR and removal of already marked todo item in this PR

@jtcohen6 jtcohen6 merged commit 57ab31d into main Jan 19, 2023
@jtcohen6 jtcohen6 deleted the jerco/convert-onschemachange-tests branch January 19, 2023 12:20
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
* Convert incremental on_schema_change tests

* Switch to dbt-core main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants