Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1630] Convert column_types test for dbt-redshift #276

Merged
merged 4 commits into from
Jan 26, 2023
Merged

[CT-1630] Convert column_types test for dbt-redshift #276

merged 4 commits into from
Jan 26, 2023

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jan 23, 2023 •
edited
Loading

resolves #dbt-labs/dbt-core#6404

Description

convesion of 056 to new functional test method

todo before merge: revert dev_requirements dbt-core pin

Checklist

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Jan 23, 2023
@McKnight-42 McKnight-42 self-assigned this Jan 23, 2023
@cla-bot cla-bot bot added the cla:yes label Jan 23, 2023
@McKnight-42 McKnight-42 mentioned this pull request Jan 23, 2023
Merged
9 tasks
@McKnight-42 McKnight-42 marked this pull request as ready for review January 24, 2023 17:00
mikealfare
mikealfare reviewed Jan 24, 2023
View reviewed changes
dev-requirements.txt Outdated Show resolved Hide resolved
@McKnight-42 McKnight-42 reopened this Jan 25, 2023
VersusFacit
VersusFacit approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@McKnight-42 McKnight-42 merged commit 047b5c2 into main Jan 26, 2023
@McKnight-42 McKnight-42 deleted the mcknight/rs-ct-1630 branch January 26, 2023 21:58
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
@McKnight-42
[CT-1630] Convert column_types test for dbt-redshift (dbt-labs#276)
b19216f 
* init conversion of columns_types test for redshift, removal of old test, dev_requirements pin changed

* reset dev-requirement pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@VersusFacit VersusFacit VersusFacit approved these changes

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@McKnight-42 @mikealfare @VersusFacit