Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to generalize constraints #393

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 4, 2023

resolves #342

Description

Uses centralized warnings from dbt-core for constraints.

Checklist

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Apr 4, 2023
@cla-bot cla-bot bot added the cla:yes label Apr 4, 2023
@emmyoop emmyoop force-pushed the er/ct-2217-constraint-support branch 2 times, most recently from a478ea0 to eeb374a Compare April 10, 2023 21:27
@emmyoop emmyoop force-pushed the er/ct-2217-constraint-support branch from 1d98442 to c9ef557 Compare April 11, 2023 18:53
@emmyoop emmyoop marked this pull request as ready for review April 11, 2023 18:53
@emmyoop emmyoop requested a review from a team as a code owner April 11, 2023 18:53
@emmyoop emmyoop requested a review from Fleid April 11, 2023 18:53
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boy I sure do love deleting Code

@emmyoop emmyoop merged commit ee1d08d into main Apr 11, 2023
@emmyoop emmyoop deleted the er/ct-2217-constraint-support branch April 11, 2023 20:19
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
* update to generalize constraints

* fix primary key logic

* remove special logic for primary key

* fix mypy

* update dev requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2217] [Redshift] Remove constraints_check warning in get_columns_spec_ddl
4 participants