Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that the behavior flag warning fires once #916

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

mikealfare
Copy link
Contributor

resolves #915

Problem

We're firing a lot of warnings. We fixed the issue in dbt-common, but we want to make sure it carries through here.

Solution

Trigger the warning a few times in different scenarios and verify that we get one warning per invocation.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Sep 20, 2024
@mikealfare mikealfare requested a review from a team as a code owner September 20, 2024 22:46
@cla-bot cla-bot bot added the cla:yes label Sep 20, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

1 similar comment
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

dev-requirements.txt Outdated Show resolved Hide resolved
@mikealfare mikealfare merged commit 93641ff into main Oct 16, 2024
40 checks passed
@mikealfare mikealfare deleted the check-behavior-flag-fires-once branch October 16, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Reduce warnings with singular restrict_direct_pg_catalog_access message
2 participants