Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #931

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Drop support for Python 3.8 #931

merged 4 commits into from
Oct 17, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

Python 3.8 reached end of life on 10/7/2024.

Solution

Drop support for Python 3.8. Update tests to no longer run on Python 3.8.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Oct 16, 2024
@mikealfare mikealfare requested a review from a team as a code owner October 16, 2024 23:02
@cla-bot cla-bot bot added the cla:yes label Oct 16, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare
Copy link
Contributor Author

mikealfare commented Oct 17, 2024

The tests are all messed up due to the change in testing matrix and the fact that they run off of main. This will be merged and verified. The resulting integration tests from this merge:
https://github.com/dbt-labs/dbt-redshift/actions/runs/11391275819

@mikealfare mikealfare merged commit 9241fcd into main Oct 17, 2024
55 of 61 checks passed
@mikealfare mikealfare deleted the remove-py38-support branch October 17, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants