forked from dbt-labs/dbt-snowflake
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Sync fork with upstream #15
Merged
alexander-smolyakov
merged 23 commits into
main
from
users/alexander-smolyakov/sync-with-upstream
Jan 17, 2023
Merged
[Misc] Sync fork with upstream #15
alexander-smolyakov
merged 23 commits into
main
from
users/alexander-smolyakov/sync-with-upstream
Jan 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
* testing temp fix for local testing by lowering pin for snowlfake-python-connector * updating to main * rolling back snowflake-connector-python to 2.8.1 while we look into file lock issue * add changelog entry * add setup.py to integration test filter * Revert "add setup.py to integration test filter" This reverts commit 0bd88c0. Co-authored-by: Colin <colin.rogers@dbtlabs.com>
* Strip potentially sensitive data from error response if present When a merge statement fails on Snowflake with a duplicate row, Snowflake will return the data from the row that failed in the format: Duplicate row detected during DML action Row Values: [12345, "col_a_value", "col_b_value", "col_c_value", "etc"...] This can potentially result in sensitive data from the warehouse being written to stdout (often captured by orchestrators) and dbt.log Resolves dbt-labs#123 / CT-443 * Add changelog generated by changie * Generalize solution to all possible row value leaks. Add test. * Get rid of now useless if gaurd. * Compile regex. Co-authored-by: Dean Verhey <deanverhey@gmail.com> Co-authored-by: Anders <anders.swanson@dbtlabs.com> Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
…porary views. (dbt-labs#379) * Add temporary key to temporary view creation macro. * add changelog * Rearrange things to work in a more general case * Add prefix to avoid name collisions and open door to future compatibility. * Cleanup methods using Jinja's extended parameter rules * Go back to a wrapped solution * Change boolean value name to reflect its type Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
* rename exceptions * changelog * point back to main * Update Under the Hood-20230110-084413.yaml
* Bumping version to 1.5.0a1 and generate CHANGELOG * update changelog for 1.5.0a1 Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
) * Only run at 7:00 am est (before folks get into the office) * Split jobs and adjust timestamps. * Trim comments. * Update .github/workflows/release-branch-tests.yml Add 1.4.latest to testing now that it exists. Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> Co-authored-by: Mila Page <versusfacit@users.noreply.github.com> Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
* Only run at 7:00 am est (before folks get into the office) * Split jobs and adjust timestamps. * Trim comments. * Need both workflows on each job. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
…lyakov/sync-with-upstream
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
emmyoop
approved these changes
Jan 17, 2023
alexander-smolyakov
deleted the
users/alexander-smolyakov/sync-with-upstream
branch
January 17, 2023 16:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Sync fork with upstream to consume recent changes