add test for incremental model #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenyuLInx
commented
Jul 13, 2022
| df = dbt.ref("m_1") | ||
| if dbt.is_incremental: | ||
| # incremental runs should only apply to | ||
| df = df.filter(df.id >= session.sql(f"select max(id) from {dbt.this}").collect()[0][0]) |
There was a problem hiding this comment.
@jtcohen6 I couldn't figure out a better way to do this with a dataframe. Probably something that we can surface with the snowpark team
There was a problem hiding this comment.
I don't really like this but also couldn't figure out a way to get around it for now even with max. I feel okay leaving it like this for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test for incremental python model
This test works fine locally, just didn't change the core version so everything is failing now