Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1100] initial snowflake conversion of concurrency test #252

Merged
merged 10 commits into from
Sep 14, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Sep 7, 2022

resolves core counterpart 5753

Description

snowflake conversion od 021_test_concurrency

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Sep 7, 2022
@McKnight-42 McKnight-42 self-assigned this Sep 7, 2022
@cla-bot cla-bot bot added the cla:yes label Sep 7, 2022
…es, change to run_dbt over run_dbt_and_capture as we don't need to pass output
@McKnight-42 McKnight-42 marked this pull request as ready for review September 9, 2022 15:53
@McKnight-42
Copy link
Contributor Author

TODO: fix new syntax error after swapping to csv method

Invoking dbt with ['seed', '--select', 'update']
22:15:17  Running with dbt=1.3.0-b2
22:15:17  Found 7 models, 0 tests, 0 snapshots, 0 analyses, 286 macros, 0 operations, 2 seed files, 0 sources, 0 exposures, 0 metrics
22:15:17
22:15:20  Concurrency: 4 threads (target='default')
22:15:20
22:15:20  1 of 1 START seed file test16630208886180667051_test_concurrency.update ........ [RUN]
22:15:22  1 of 1 ERROR loading seed file test16630208886180667051_test_concurrency.update  [ERROR in 1.40s]
22:15:22
22:15:22  Finished running 1 seed in 0 hours 0 minutes and 4.68 seconds (4.68s).
22:15:22
22:15:22  Completed with 1 error and 0 warnings:
22:15:22
22:15:22  Database Error in seed update (seeds/update.csv)
22:15:22    001003 (42000): SQL compilation error:
22:15:22    syntax error line 1 at position 63 unexpected '.'.
22:15:22
22:15:22  Done. PASS=0 WARN=0 ERROR=1 SKIP=0 TOTAL=1

not seeing anything particular sticking out in the seed in core test seeds__update_csv.

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@mcknight/convert-021_concurrency_tests#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@mcknight/convert-021_concurrency_tests#egg=dbt-tests-adapter&subdirectory=tests/adapter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed before merge

@McKnight-42 McKnight-42 merged commit 6748104 into main Sep 14, 2022
@McKnight-42 McKnight-42 deleted the mcknight/convert_concurrency_test branch September 14, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants